Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log collection panic #1711

Merged
merged 1 commit into from
Dec 28, 2023
Merged

log collection panic #1711

merged 1 commit into from
Dec 28, 2023
+8 −2

Conversation

mrpalide
Copy link
Contributor

Did you run make format && make check? Yes

Fixes #_

Changes:

  • add condition for v.Version on blank visors
  • add timeout for http request to UT data

How to test this PR:

  • run go run ./cmd/skywire-cli/skywire-cli.go log

@0pcom 0pcom merged commit 376ae61 into skycoin:develop Dec 28, 2023
3 checks passed
@0pcom 0pcom mentioned this pull request Dec 28, 2023
Closed
@mrpalide mrpalide deleted the fix/log-collection-panic branch March 26, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrpalide @0pcom